Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/194] 매칭 수정사항 변경 및 ErrorStatus 변경 #195

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

rimi3226
Copy link
Contributor

@rimi3226 rimi3226 commented Aug 28, 2024

🚀 개요

매칭 수정사항 변경 및 ErrorStatus 변경

🔍 변경사항

  • ErrorStatus 이효림 작업 부분 중복 없도록 변경
  • 포지션 겹칠 때 랜덤일 경우 우선순위 0 안되도록 변경
  • 매너레벨 가중치 4->3 변경
  • 차단한 회원일 경우 우선순위 리스트에서 제외

⏳ 작업 내용

  • ErrorStatus 이효림 작업 부분 중복 없도록 변경
  • 포지션 겹칠 때 랜덤일 경우 우선순위 0 안되도록 변경
  • 매너레벨 가중치 4->3 변경
  • 차단한 회원일 경우 우선순위 리스트에서 제외

📝 논의사항

@rimi3226 rimi3226 requested review from Eunjin3395 and hzee97 August 28, 2024 17:04
@rimi3226 rimi3226 self-assigned this Aug 28, 2024
@rimi3226 rimi3226 linked an issue Aug 28, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@Eunjin3395 Eunjin3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Comment on lines +78 to +80
// 서로 차단한 사용자일 경우 우선순위 계산 X
if (blockRepository.existsByBlockerMemberAndBlockedMember(member, record.getMember())) {
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그럼 차단한 사용자끼리는 우선순위 점수가 0점이 아니라 아예 그냥 계산 제외가 되는 것일까요?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 네넵 맞아요!

Copy link
Contributor

@hzee97 hzee97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@rimi3226 rimi3226 merged commit f94e403 into develop Sep 3, 2024
1 check passed
@rimi3226 rimi3226 deleted the fix/194 branch September 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Fix] 매칭 우선순위 점수 변경하기 및 매칭 수정사항 반영
3 participants